[FFmpeg-trac] #1755(avformat:open): Incorrect timestamps for aac in avi
FFmpeg
trac at avcodec.org
Wed Oct 10 07:57:37 CEST 2012
#1755: Incorrect timestamps for aac in avi
-------------------------------------+------------------------------------
Reporter: Heesuk Jung | Owner:
Type: defect | Status: open
Priority: normal | Component: avformat
Version: git-master | Resolution:
Keywords: avi aac pts | Blocked By:
Blocking: | Reproduced by developer: 1
Analyzed by developer: 0 |
-------------------------------------+------------------------------------
Comment (by Heesuk Jung):
Hi cehoyos,
I fixed this issue.
Please refer my summary as below.
-----------------------------------------------------------------------------
Use sample size in case incorrect timestamps for aac in AVI (Ticket #1755)
In some case for aac in AVI, avidec extracts wrong PTS value.
(www.ffmpeg.org/trac/ffmpeg/ticket/1755)
In getDuration function, I suggest using sample size instead of len.
I attached 4 files.
- avidec.c
- In latest master, I merged my patch into avidec.c
- avidec.patch
- patch file
- frameInfo_withoutPatch.txt
- There are frame informations without patch. As you know, PTS value is
wrong.
- 1X playback is NG and seek is NG too.
- frameInfo_withPatch.txt
- There are frame informations without patch. As you know, PTS value is
ok.
- 1X playback is ok and seek is ok too.
Also I have done regression test in our media pool.
Test result of 11 problematic files is ok after patch apply.
(11 files have fixed sample size in AVI Stream Header)
Regression test reseult of 4 non-problematic files is ok after patch
apply.
(4 files have variable sample size in AVI Stream Header)
-----------------------------------------------------------------------------
I have 1 question to commit change.
I got ffmpeg master branch but master git is read-only and so
I hope to know how I can submit change into master branch?
(I want to know change commit process or needing some admission.)
Thanks
--
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1755#comment:8>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list