[FFmpeg-trac] #2909(avcodec:new): Make dvbsubs more compliant among stb's
FFmpeg
trac at avcodec.org
Mon Sep 23 11:53:42 CEST 2013
#2909: Make dvbsubs more compliant among stb's
-------------------------------------+-----------------------------------
Reporter: tommy2d | Owner:
Type: enhancement | Status: new
Priority: normal | Component: avcodec
Version: 1.2.2 | Resolution:
Keywords: dvbsub | Blocked By:
Blocking: | Reproduced by developer: 0
Analyzed by developer: 0 |
-------------------------------------+-----------------------------------
Comment (by ubitux):
Replying to [ticket:2909 tommy2d]:
> [...]
> 1. Make sure all reserved bits, especially in the region composition
segment, are set to 0 rather than 1:
>
> {{{
> - *q++ = ((1 + bpp_index) << 5) | ((1 + bpp_index) << 2) | 0x03;
> + *q++ = ((1 + bpp_index) << 5) | ((1 + bpp_index) << 2) | 0x00;
>
> - *q++ = 0xf0 | ((y >> 8) & 0xf);
> + *q++ = 0x00 | ((y >> 8) & 0xf);
> }}}
>
I can't find the second chunk in our codebase. For the record, the first
one is from {{{lavc/dvbsub.c}}}.
> [...]
> That's about it. I know this feature is not used a lot, especially since
the mpeg-ts muxer provided by ffmpeg is not really suitable for
broadcasting purposes, but these minor changes really contribute to the
compatibility of the dvbsubs that avcodec encodes.
You are talking about a lot of changes, could you just send a patch? As
Carl said, we can't really make much sense about what you are sharing.
And you are wrong about FFmpeg not being suitable for broadcasting
purposes BTW. But OTOH the DVB subtitles support is definitely in need of
some improvements, so your changes will be really appreciated.
--
Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2909#comment:4>
FFmpeg <http://ffmpeg.org>
FFmpeg issue tracker
More information about the FFmpeg-trac
mailing list